Skip to content

[PWGJE] add parametrised model fast sim#2375

Open
aimeric-landou wants to merge 4 commits into
AliceO2Group:masterfrom
aimeric-landou:parametrisedModelClosureTest
Open

[PWGJE] add parametrised model fast sim#2375
aimeric-landou wants to merge 4 commits into
AliceO2Group:masterfrom
aimeric-landou:parametrisedModelClosureTest

Conversation

@aimeric-landou

Copy link
Copy Markdown
Contributor

For closure checks with regard to combinatorial background.

Added tests as requested in previous PR.

@aimeric-landou aimeric-landou requested a review from a team as a code owner June 8, 2026 16:53
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@nzardosh

nzardosh commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@jackal1-66 could you take a look please and see if its ok from your end?

@jackal1-66

Copy link
Copy Markdown
Collaborator

Hello @aimeric-landou can you please move the ini files directly in the ini folder? That's our standard and the CI is not able to recognise you added generators configuration otherwise

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@aimeric-landou

aimeric-landou commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I was missing one of the config files the simulations fetch from alien; I added it and closed/reopened the PR to get the tests to run again

@jackal1-66

Copy link
Copy Markdown
Collaborator

CI is green, but there seems to be a randomic effect. Not to merge before this has been addressed

Comment on lines +183 to +186
if (mDebug) {
cout << "####################### creating partons signal #######################" << endl;
cout << "AIMERIC: signal, count " << nJets << " for mNJetsAverage = " << mNJetsAverage << "" << endl;
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use LOG(debug) for this purpose. Moreover remove "AIMERIC" from the log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants